[PATCH 1/3] S12Z: Remove diagnostic printf statement.

[John Darrington]

* bfd/elf32-s12z.c (bfd_elf32_bfd_reloc_name_lookup): Remove diagnostic printf
(artifact from debugging)
---
bfd/elf32-s12z.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/bfd/elf32-s12z.c b/bfd/elf32-s12z.c
index cab54c487b..150be12c2c 100644
--- a/bfd/elf32-s12z.c
+++ b/bfd/elf32-s12z.c
@@ -243,8 +243,6 @@ bfd_elf32_bfd_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
{
unsigned int i;

- printf ("%s:%d Looking up %s\n", __FILE__, __LINE__, r_name);
-
for (i = 0;
i < (sizeof (elf_s12z_howto_table)
/ sizeof (elf_s12z_howto_table[0]));

[John Darrington]

Thanks to Alan Modra for this hint.

* bfd/elf32-s12z.c (elf_s12z_howto_table): set all src_mask members to zero.
---
bfd/elf32-s12z.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bfd/elf32-s12z.c b/bfd/elf32-s12z.c
index 150be12c2c..d2ea4ecaf2 100644
--- a/bfd/elf32-s12z.c
+++ b/bfd/elf32-s12z.c
@@ -119,7 +119,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
shift_addend_reloc,
"R_S12Z_OPR", /* name */
FALSE, /* partial_inplace */
- 0x00ffffff, /* src_mask */
+ 0x00000000, /* src_mask */
0x00ffffff, /* dst_mask */
FALSE), /* pcrel_offset */

@@ -164,7 +164,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
bfd_elf_generic_reloc, /* special_function */
"R_S12Z_EXT24", /* name */
FALSE, /* partial_inplace */
- 0x00ffffff, /* src_mask */
+ 0x00000000, /* src_mask */
0x00ffffff, /* dst_mask */
FALSE), /* pcrel_offset */

@@ -179,7 +179,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
opru18_reloc, /* special_function */
"R_S12Z_EXT18", /* name */
FALSE, /* partial_inplace */
- 0x0005ffff, /* src_mask */
+ 0x00000000, /* src_mask */
0x0005ffff, /* dst_mask */
FALSE), /* pcrel_offset */

@@ -194,7 +194,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
bfd_elf_generic_reloc, /* special_function */
"R_S12Z_EXT32", /* name */
FALSE, /* partial_inplace */
- 0xffffffff, /* src_mask */
+ 0x00000000, /* src_mask */
0xffffffff, /* dst_mask */
FALSE), /* pcrel_offset */
};

[John Darrington]

Ping!
On Wed, Sep 05, 2018 at 02:30:12PM +0200, John Darrington wrote:
Thanks to Alan Modra for this hint.

* bfd/elf32-s12z.c (elf_s12z_howto_table): set all src_mask members to zero.
---
bfd/elf32-s12z.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bfd/elf32-s12z.c b/bfd/elf32-s12z.c
index 150be12c2c..d2ea4ecaf2 100644
--- a/bfd/elf32-s12z.c
+++ b/bfd/elf32-s12z.c
@@ -119,7 +119,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
shift_addend_reloc,
"R_S12Z_OPR", /* name */
FALSE, /* partial_inplace */
- 0x00ffffff, /* src_mask */
+ 0x00000000, /* src_mask */
0x00ffffff, /* dst_mask */
FALSE), /* pcrel_offset */

@@ -164,7 +164,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
bfd_elf_generic_reloc, /* special_function */
"R_S12Z_EXT24", /* name */
FALSE, /* partial_inplace */
- 0x00ffffff, /* src_mask */
+ 0x00000000, /* src_mask */
0x00ffffff, /* dst_mask */
FALSE), /* pcrel_offset */

@@ -179,7 +179,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
opru18_reloc, /* special_function */
"R_S12Z_EXT18", /* name */
FALSE, /* partial_inplace */
- 0x0005ffff, /* src_mask */
+ 0x00000000, /* src_mask */
0x0005ffff, /* dst_mask */
FALSE), /* pcrel_offset */

@@ -194,7 +194,7 @@ static reloc_howto_type elf_s12z_howto_table[] =
bfd_elf_generic_reloc, /* special_function */
"R_S12Z_EXT32", /* name */
FALSE, /* partial_inplace */
- 0xffffffff, /* src_mask */
+ 0x00000000, /* src_mask */
0xffffffff, /* dst_mask */
FALSE), /* pcrel_offset */
};
--
2.11.0

[Nick Clifton]

Hi John,

Post by John Darrington
Ping!

Sorry again.

Post by John Darrington
* bfd/elf32-s12z.c (elf_s12z_howto_table): set all src_mask members to zero.

Approved - please apply.

Cheers
Nick

[John Darrington]

* ld/testsuite/ld-s12z/z12s.exp: Delete.
* ld/testsuite/ld-s12z/s12z.exp: New file.
---
ld/testsuite/ld-s12z/{z12s.exp => s12z.exp} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename ld/testsuite/ld-s12z/{z12s.exp => s12z.exp} (100%)

diff --git a/ld/testsuite/ld-s12z/z12s.exp b/ld/testsuite/ld-s12z/s12z.exp
similarity index 100%
rename from ld/testsuite/ld-s12z/z12s.exp
rename to ld/testsuite/ld-s12z/s12z.exp

[John Darrington]

Ping!
On Wed, Sep 05, 2018 at 02:30:11PM +0200, John Darrington wrote:
* bfd/elf32-s12z.c (bfd_elf32_bfd_reloc_name_lookup): Remove diagnostic printf
(artifact from debugging)
---
bfd/elf32-s12z.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/bfd/elf32-s12z.c b/bfd/elf32-s12z.c
index cab54c487b..150be12c2c 100644
--- a/bfd/elf32-s12z.c
+++ b/bfd/elf32-s12z.c
@@ -243,8 +243,6 @@ bfd_elf32_bfd_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
{
unsigned int i;

- printf ("%s:%d Looking up %s\n", __FILE__, __LINE__, r_name);
-
for (i = 0;
i < (sizeof (elf_s12z_howto_table)
/ sizeof (elf_s12z_howto_table[0]));
--
2.11.0

[Nick Clifton]

Hi John,

Post by John Darrington
Ping!

Sorry!

Post by John Darrington
* bfd/elf32-s12z.c (bfd_elf32_bfd_reloc_name_lookup): Remove diagnostic printf
(artifact from debugging)

Approved - please apply.

Cheers
Nick