Discussion:
[PATCH] CSKY: About PC relative diff relocation
Lifang Xia
2018-09-10 02:09:50 UTC
Permalink
Hi everyone,

Here is a patch about PC relative diff relocation in CSKY.

bfd:
            * elf32-csky.c (csky_elf_howto_table): Fill special_function of
            R_CKCORE_PCREL32.
            (csky_elf_relocate_section): Add R_CKCORE_PCREL32 process.
gas:
            * config/tc-csky.c (md_apply_fix): Transmit
            BFD_RELOC_32_PCREL to BFD_RELOC_CKCORE_PCREL32.
            (tc_gen_reloc): Trasmit BFD_RELOC_CKCORE_ADDR32 to
            BFD_RELOC_CKCORE_PCREL32 while pc-relative.
            * config/tc-csky.h (DIFF_EXPR_OK): Define to enable PC relative
            diff relocs.

Can anyone review and commit it?


Thanks.

Lifang.
Lifang Xia
2018-09-13 08:54:38 UTC
Permalink
Hi everyone,

I have already requested a account to access bintuils-gdb, what should I
do next if I want to push this patch?
Can I push it to the master directly by "git push"?

Thanks.
Post by Lifang Xia
Hi everyone,
Here is a patch about PC relative diff relocation in CSKY.
            * elf32-csky.c (csky_elf_howto_table): Fill
special_function of
            R_CKCORE_PCREL32.
            (csky_elf_relocate_section): Add R_CKCORE_PCREL32 process.
            * config/tc-csky.c (md_apply_fix): Transmit
            BFD_RELOC_32_PCREL to BFD_RELOC_CKCORE_PCREL32.
            (tc_gen_reloc): Trasmit BFD_RELOC_CKCORE_ADDR32 to
            BFD_RELOC_CKCORE_PCREL32 while pc-relative.
            * config/tc-csky.h (DIFF_EXPR_OK): Define to enable PC
relative
            diff relocs.
Can anyone review and commit it?
Thanks.
Lifang.
Nick Clifton
2018-09-17 15:31:56 UTC
Permalink
Hi Lifang,
            * elf32-csky.c (csky_elf_howto_table): Fill special_function of
            R_CKCORE_PCREL32.
            (csky_elf_relocate_section): Add R_CKCORE_PCREL32 process.
            * config/tc-csky.c (md_apply_fix): Transmit
            BFD_RELOC_32_PCREL to BFD_RELOC_CKCORE_PCREL32.
            (tc_gen_reloc): Trasmit BFD_RELOC_CKCORE_ADDR32 to
            BFD_RELOC_CKCORE_PCREL32 while pc-relative.
            * config/tc-csky.h (DIFF_EXPR_OK): Define to enable PC relative
            diff relocs.
Approved - please apply. (Sorry for the delay in reviewing).

Cheers
Nick

Loading...