Discussion:
[PATCH] opcodes/nfp: Fix disassembly of crc[] with swapped operands.
Francois H. Theron
2018-11-01 15:57:23 UTC
Permalink
The decoding of the CRC operation in alu instructions was using bits
from the instruction word directly, instead of srcA which would be
different if the swap bit was set.

Signed-off-by: Francois H. Theron <***@netronome.com>
---
binutils/ChangeLog | 4 +++
binutils/testsuite/binutils-all/nfp/test1.d | 32 +++++++++++++++---
.../binutils-all/nfp/test1_nfp6000.nffw | Bin 9880 -> 10128 bytes
opcodes/ChangeLog | 4 +++
opcodes/nfp-dis.c | 12 +++----
5 files changed, 42 insertions(+), 10 deletions(-)
Nick Clifton
2018-11-06 16:45:55 UTC
Permalink
Hi Francois,
Post by Francois H. Theron
The decoding of the CRC operation in alu instructions was using bits
from the instruction word directly, instead of srcA which would be
different if the swap bit was set.
Approved - please apply.

Cheers
Nick

Loading...