Discussion:
[PATCH] readelf: Prune gaps in build notes
H.J. Lu
2018-11-19 20:48:48 UTC
Permalink
Since not all files have build notes, it is normal to have gaps in build
notes.

PR binutils/23898
* testsuite/lib/binutils-common.exp (prune_warnings_extra):
Prune gaps in build notes.
---
binutils/testsuite/lib/binutils-common.exp | 2 ++
1 file changed, 2 insertions(+)

diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index f1a153193c..bbbbfbe8ad 100644
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -442,6 +442,8 @@ proc prune_warnings_extra { text } {
# The "\\1" is to try to preserve a "\n" but only if necessary.
regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*unsupported GNU_PROPERTY_TYPE\[^\n\]*\n?)+" $text "\\1" text
}
+ # PR binutils/23898: It is OK to have gaps in build notes.
+ regsub -all "(^|\n)(\[^\n\]*: Warning: Gap in build notes detected from\[^\n\]*\n?)+" $text "\\1" text
return $text
}
--
2.19.1
H.J. Lu
2018-11-20 14:41:08 UTC
Permalink
Post by H.J. Lu
Since not all files have build notes, it is normal to have gaps in build
notes.
PR binutils/23898
Prune gaps in build notes.
---
binutils/testsuite/lib/binutils-common.exp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index f1a153193c..bbbbfbe8ad 100644
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -442,6 +442,8 @@ proc prune_warnings_extra { text } {
# The "\\1" is to try to preserve a "\n" but only if necessary.
regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*unsupported GNU_PROPERTY_TYPE\[^\n\]*\n?)+" $text "\\1" text
}
+ # PR binutils/23898: It is OK to have gaps in build notes.
+ regsub -all "(^|\n)(\[^\n\]*: Warning: Gap in build notes detected from\[^\n\]*\n?)+" $text "\\1" text
return $text
}
--
2.19.1
I am checking it in.
--
H.J.
Loading...