Discussion:
[PATCH] Skip elf/section14 test for h8300 targets
H.J. Lu
2018-08-30 18:08:14 UTC
Permalink
Skip elf/section14 test for h8300 targets since the h8300 port issues a
warning message for new sections created without atrributes.

* testsuite/gas/elf/section14.d: Skip h8300 targets.
---
gas/ChangeLog | 4 ++++
gas/testsuite/gas/elf/section14.d | 3 +++
2 files changed, 7 insertions(+)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index aa8633a98f..e8809176eb 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2018-08-30 H.J. Lu <***@intel.com>
+
+ * testsuite/gas/elf/section14.d: Skip h8300 targets.
+
2018-08-30 H.J. Lu <***@intel.com>

* testsuite/gas/elf/elf.exp: Run section14.
diff --git a/gas/testsuite/gas/elf/section14.d b/gas/testsuite/gas/elf/section14.d
index 82b8a776ce..d4fafa2b1d 100644
--- a/gas/testsuite/gas/elf/section14.d
+++ b/gas/testsuite/gas/elf/section14.d
@@ -1,6 +1,9 @@
#name: array sections
#as: --no-pad-sections
#readelf: -S --wide
+# The h8300 port issues a warning message for new sections created
+# without atrributes.
+#skip: h8300-*

There are [0-9]+ section headers, starting at offset 0x[0-9a-f]+:
--
2.17.1
Alan Modra
2018-08-31 16:23:13 UTC
Permalink
Post by H.J. Lu
--- a/gas/testsuite/gas/elf/section14.d
+++ b/gas/testsuite/gas/elf/section14.d
@@ -1,6 +1,9 @@
#name: array sections
#as: --no-pad-sections
#readelf: -S --wide
+# The h8300 port issues a warning message for new sections created
+# without atrributes.
attributes
Post by H.J. Lu
+#skip: h8300-*
OK with this changed to xfail. That way we get an XPASS when port
peculiarities are fixed, and will fix the testsuite too.
--
Alan Modra
Australia Development Lab, IBM
H.J. Lu
2018-08-31 16:43:40 UTC
Permalink
Post by Alan Modra
Post by H.J. Lu
--- a/gas/testsuite/gas/elf/section14.d
+++ b/gas/testsuite/gas/elf/section14.d
@@ -1,6 +1,9 @@
#name: array sections
#as: --no-pad-sections
#readelf: -S --wide
+# The h8300 port issues a warning message for new sections created
+# without atrributes.
attributes
Post by H.J. Lu
+#skip: h8300-*
OK with this changed to xfail. That way we get an XPASS when port
peculiarities are fixed, and will fix the testsuite too.
This is what I checked in.
--
H.J.
Alan Modra
2018-09-01 00:58:09 UTC
Permalink
Post by Alan Modra
Post by H.J. Lu
--- a/gas/testsuite/gas/elf/section14.d
+++ b/gas/testsuite/gas/elf/section14.d
@@ -1,6 +1,9 @@
#name: array sections
#as: --no-pad-sections
#readelf: -S --wide
+# The h8300 port issues a warning message for new sections created
+# without atrributes.
attributes
Post by H.J. Lu
+#skip: h8300-*
OK with this changed to xfail. That way we get an XPASS when port
peculiarities are fixed, and will fix the testsuite too.
Sorry, I didn't realize we lacked xfail support in the gas version of
run_dump_test when I wrote the above.
* testsuite/lib/gas-defs.exp (run_dump_test): Add xfail support.
But it's nice to have this!
--
Alan Modra
Australia Development Lab, IBM
Loading...