[patch, testsuite] skip broken test on Windows

[Sandra Loosemore]

This patch is a followup to PR23153, in which it was reported that gas's
inode comparison test for identical input and output files doesn't work
on MinGW hosts, so it was disabled. Now the test case that is supposed
to verify that a diagnostic is issued not only FAILs, it also ends up
overwriting its input file -- which is used by another test too, so that
FAILs as well. It seems like the solution is "don't do that".

OK to commit?

-Sandra

[Nick Clifton]

Hi Sandra,

This patch is a followup to PR23153, in which it was reported that gas's inode comparison test for identical input and output files doesn't work on MinGW hosts,

Is this still the case ? We did make some improvements to the code
(So that it also checks the st_dev field, and if the inode is 0,
then the check is assumed to have failed).

Cheers
Nick

[Sandra Loosemore]

Post by Nick Clifton
Hi Sandra,

This patch is a followup to PR23153, in which it was reported that gas's inode comparison test for identical input and output files doesn't work on MinGW hosts,

Is this still the case ? We did make some improvements to the code
(So that it also checks the st_dev field, and if the inode is 0,
then the check is assumed to have failed).

It does not diagnose the error if both input and output files have inode
0 (which is what happens on mingw host). So, instead of producing the
expected error, the testcase proceeds to overwrite its input file. This
is bad. :-(

-Sandra

[Nick Clifton]

Hi Sandra,

It does not diagnose the error if both input and output files have inode 0 (which is what happens on mingw host).  So, instead of producing the expected error, the testcase proceeds to overwrite its input file.  This is bad.  :-(

Ah yes, I had it the wrong way round in my head. Thanks for clearing it up.

Patch approved - please apply.

Cheers
Nick