[PATCH] elf32-nds32: Remove elf32_nds32_allocate_dynrelocs

[Simon Marchi]

It is unused, removing it fixes this error when building with clang:

/home/emaisin/src/binutils-gdb/bfd/elf32-nds32.c:3172:1: error: unused function 'elf32_nds32_allocate_dynrelocs' [-Werror,-Wunused-function]
elf32_nds32_allocate_dynrelocs (struct bfd_link_info *info, asection *sreloc,
^
1 error generated.

gcc only reports the error if you remove "inline". I don't know if this
is actually a mistake and it should actually be used though.

gdb/ChangeLog:

* elf32-nds32.c (elf32_nds32_allocate_dynrelocs): Remove.
---
bfd/elf32-nds32.c | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c
index 6215f288009..a4f5ca4dc33 100644
--- a/bfd/elf32-nds32.c
+++ b/bfd/elf32-nds32.c
@@ -3165,19 +3165,6 @@ static const struct nds32_reloc_map_entry nds32_reloc_map[] =

/* Patch tag. */

-/* Reserve space for COUNT dynamic relocations in relocation selection
- SRELOC. */
-
-static inline void
-elf32_nds32_allocate_dynrelocs (struct bfd_link_info *info, asection *sreloc,
- bfd_size_type count)
-{
- BFD_ASSERT (elf_hash_table (info)->dynamic_sections_created);
- if (sreloc == NULL)
- abort ();
- sreloc->size += sizeof (Elf32_External_Rela) * count;
-}
-
static reloc_howto_type *
bfd_elf32_bfd_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
const char *r_name)

[Kuan-Lin Chen]

OK. Thanks.

Post by Simon Marchi
/home/emaisin/src/binutils-gdb/bfd/elf32-nds32.c:3172:1: error: unused function 'elf32_nds32_allocate_dynrelocs' [-Werror,-Wunused-function]
elf32_nds32_allocate_dynrelocs (struct bfd_link_info *info, asection *sreloc,
^
1 error generated.
gcc only reports the error if you remove "inline". I don't know if this
is actually a mistake and it should actually be used though.
* elf32-nds32.c (elf32_nds32_allocate_dynrelocs): Remove.
---
bfd/elf32-nds32.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c
index 6215f288009..a4f5ca4dc33 100644
--- a/bfd/elf32-nds32.c
+++ b/bfd/elf32-nds32.c
@@ -3165,19 +3165,6 @@ static const struct nds32_reloc_map_entry nds32_reloc_map[] =
/* Patch tag. */
-/* Reserve space for COUNT dynamic relocations in relocation selection
- SRELOC. */
-
-static inline void
-elf32_nds32_allocate_dynrelocs (struct bfd_link_info *info, asection *sreloc,
- bfd_size_type count)
-{
- BFD_ASSERT (elf_hash_table (info)->dynamic_sections_created);
- if (sreloc == NULL)
- abort ();
- sreloc->size += sizeof (Elf32_External_Rela) * count;
-}
-
static reloc_howto_type *
bfd_elf32_bfd_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
const char *r_name)
--
2.19.0

[Simon Marchi]

Post by Kuan-Lin Chen
OK. Thanks.

Thanks, pushed.

Simon