Discussion:
[GAS][ARM] Fix ARMv8.1 AdvSIMD testism
Andre Vieira (lists)
2018-10-19 14:59:48 UTC
Permalink
Hi,

This patch fixes a testism.
This test never used to test the output of objdump as the old 'error-output'
check would exit after verifying the output in stdout and stderr from the
assembler. Given the use of warning_output now, the objdump runs and
expects
its output to be verified. Assuming the correct disassembly of these
instructions is tested elsewhere given we never tested them here, this patch
removes the objdump run.

Is this OK for trunk?

gas/ChangeLog

2018-10-19 Andre Vieira <***@arm.com>

* testsuite/gas/arm/armv8-a+rdma-warning.d: Remove
objdump execution.
Thomas Preudhomme
2018-10-26 10:27:31 UTC
Permalink
Hi Andre,

On Fri, 19 Oct 2018 at 16:00, Andre Vieira (lists)
Post by Andre Vieira (lists)
Hi,
This patch fixes a testism.
This test never used to test the output of objdump as the old 'error-output'
check would exit after verifying the output in stdout and stderr from the
assembler. Given the use of warning_output now, the objdump runs and
expects
its output to be verified. Assuming the correct disassembly of these
instructions is tested elsewhere given we never tested them here, this patch
removes the objdump run.
It is indeed in gas/testsuite/gas/arm/armv8-a+rdma.d

Patch therefore looks good to me. I'm not a maintainer though so
you'll need someone else to approve.

Best regards,

Thomas
Post by Andre Vieira (lists)
Is this OK for trunk?
gas/ChangeLog
* testsuite/gas/arm/armv8-a+rdma-warning.d: Remove
objdump execution.
Andre Vieira (lists)
2018-10-30 11:18:52 UTC
Permalink
Post by Thomas Preudhomme
Hi Andre,
On Fri, 19 Oct 2018 at 16:00, Andre Vieira (lists)
Post by Andre Vieira (lists)
Hi,
This patch fixes a testism.
This test never used to test the output of objdump as the old 'error-output'
check would exit after verifying the output in stdout and stderr from the
assembler. Given the use of warning_output now, the objdump runs and
expects
its output to be verified. Assuming the correct disassembly of these
instructions is tested elsewhere given we never tested them here, this patch
removes the objdump run.
It is indeed in gas/testsuite/gas/arm/armv8-a+rdma.d
Patch therefore looks good to me. I'm not a maintainer though so
you'll need someone else to approve.
Best regards,
Thomas
Post by Andre Vieira (lists)
Is this OK for trunk?
gas/ChangeLog
* testsuite/gas/arm/armv8-a+rdma-warning.d: Remove
objdump execution.
Ping.
Ramana Radhakrishnan
2018-10-30 15:30:10 UTC
Permalink
On Fri, Oct 19, 2018 at 4:00 PM Andre Vieira (lists)
Post by Andre Vieira (lists)
Hi,
This patch fixes a testism.
This test never used to test the output of objdump as the old 'error-output'
check would exit after verifying the output in stdout and stderr from the
assembler. Given the use of warning_output now, the objdump runs and
expects
its output to be verified. Assuming the correct disassembly of these
instructions is tested elsewhere given we never tested them here, this patch
removes the objdump run.
Is this OK for trunk?
OK.

Ramana
Post by Andre Vieira (lists)
gas/ChangeLog
* testsuite/gas/arm/armv8-a+rdma-warning.d: Remove
objdump execution.
Loading...