[PATCH][Binutils][Arm][committed] Skip new binary decode tests on pe targets

[Tamar Christina]

Hi All,

The two new test I added require the use of the ".inst" directive which the PE
targets don't support. Because of that I excluded *-unknown-pe but the mask needs
to be wider. I am now excluding *-*-pe.

Cross-compiled and regtested on
arm-none-eabi, arm-wince-pe

and no issues.

Committed to master and binutils-2.31 branch under the obvious rule.

Thanks,
Tamar

gas/ChangeLog:
2018-10-19 Tamar Christina <***@arm.com>

* testsuite/gas/arm/undefined-insn-arm.d: Widen pe skip.
* testsuite/gas/arm/undefined-insn-thumb.d: Likewise.

--

[Richard Earnshaw (lists)]

Post by Tamar Christina
Hi All,
The two new test I added require the use of the ".inst" directive which the PE
targets don't support. Because of that I excluded *-unknown-pe but the mask needs
to be wider. I am now excluding *-*-pe.
Cross-compiled and regtested on
arm-none-eabi, arm-wince-pe
and no issues.
Committed to master and binutils-2.31 branch under the obvious rule.
Thanks,
Tamar
* testsuite/gas/arm/undefined-insn-arm.d: Widen pe skip.
* testsuite/gas/arm/undefined-insn-thumb.d: Likewise.

There's really no reason (other than nobody's done it) why all configs
can't support .inst - it's nothing to do with the object format.

It would be even nicer to see a patch that just removes that wart.

R.

Post by Tamar Christina
rb10111.patch
diff --git a/gas/testsuite/gas/arm/undefined-insn-arm.d b/gas/testsuite/gas/arm/undefined-insn-arm.d
index 265a507d3b722332d3dc1f501d54f1cb79754682..2dc148bb7c5ab1ab153144a4c24e7c1bce10ca2b 100644
--- a/gas/testsuite/gas/arm/undefined-insn-arm.d
+++ b/gas/testsuite/gas/arm/undefined-insn-arm.d
@@ -1,5 +1,5 @@
#name: Undefined binary printing in arm mode
-#skip: *-unknown-pe *-*-vxworks
+#skip: *-*-pe *-*-vxworks
#source: undefined-insn.s
#objdump: -D -b binary -m armv7e-m
#...
diff --git a/gas/testsuite/gas/arm/undefined-insn-thumb.d b/gas/testsuite/gas/arm/undefined-insn-thumb.d
index 72385f0818f3dec33d409561b40559779feff172..8297f95a66f07ee41bebd28984845b2e7079bf7d 100644
--- a/gas/testsuite/gas/arm/undefined-insn-thumb.d
+++ b/gas/testsuite/gas/arm/undefined-insn-thumb.d
@@ -1,5 +1,5 @@
#name: Undefined binary printing in thumb mode
-#skip: *-unknown-pe *-*-vxworks
+#skip: *-*-pe *-*-vxworks
#source: undefined-insn.s
#objdump: -D -b binary -m armv7e-m -M force-thumb
#...