[GAS][ARM] Fix failing Armv1 test

[Andre Vieira (lists)]

Hi,

This patch fixes a testism. This test has been failing for a while and
it could be argued that since we started testing 'arm7t' here (and not
Armv1) the test itself was wrong. So I changed the assembly to Armv1.
Given the changes to objdump when "disassembling all" it seemed like a
good idea to force the disassembly to 'armv2' instead and actually
accept the disassembly of the 26-bit Architecture variants of tst, teq,
cmn and cmp.

Is this OK for trunk?

gas/ChangeLog

2018-10-19 Andre Vieira <***@arm.com>

* testsuite/gas/arm/armv1.d: Assemble for Armv1
and disassemble for Armv2-

[Thomas Preudhomme]

Hi Andre,

Thanks for doing this. The change looks good to me but I'm not a
maintainer so you'll not someone else to approve.

Best regards,

Thomas
On Fri, 19 Oct 2018 at 16:01, Andre Vieira (lists)

Post by Andre Vieira (lists)
Hi,
This patch fixes a testism. This test has been failing for a while and
it could be argued that since we started testing 'arm7t' here (and not
Armv1) the test itself was wrong. So I changed the assembly to Armv1.
Given the changes to objdump when "disassembling all" it seemed like a
good idea to force the disassembly to 'armv2' instead and actually
accept the disassembly of the 26-bit Architecture variants of tst, teq,
cmn and cmp.
Is this OK for trunk?
gas/ChangeLog
* testsuite/gas/arm/armv1.d: Assemble for Armv1
and disassemble for Armv2-

[Andre Vieira (lists)]

Post by Thomas Preudhomme
Hi Andre,
Thanks for doing this. The change looks good to me but I'm not a
maintainer so you'll not someone else to approve.
Best regards,
Thomas
On Fri, 19 Oct 2018 at 16:01, Andre Vieira (lists)

Post by Andre Vieira (lists)
Hi,
This patch fixes a testism. This test has been failing for a while and
it could be argued that since we started testing 'arm7t' here (and not
Armv1) the test itself was wrong. So I changed the assembly to Armv1.
Given the changes to objdump when "disassembling all" it seemed like a
good idea to force the disassembly to 'armv2' instead and actually
accept the disassembly of the 26-bit Architecture variants of tst, teq,
cmn and cmp.
Is this OK for trunk?
gas/ChangeLog
* testsuite/gas/arm/armv1.d: Assemble for Armv1
and disassemble for Armv2-

Ping

[Ramana Radhakrishnan]

On Fri, Oct 19, 2018 at 4:01 PM Andre Vieira (lists)

Post by Andre Vieira (lists)
Hi,
This patch fixes a testism. This test has been failing for a while and
it could be argued that since we started testing 'arm7t' here (and not
Armv1) the test itself was wrong. So I changed the assembly to Armv1.
Given the changes to objdump when "disassembling all" it seemed like a
good idea to force the disassembly to 'armv2' instead and actually
accept the disassembly of the 26-bit Architecture variants of tst, teq,
cmn and cmp.
Is this OK for trunk?

Ok,
At some point I would like to consider moving gas up to armv4 as well
in line with gcc but it will take a long(er) time.

Ramana

Post by Andre Vieira (lists)
gas/ChangeLog
* testsuite/gas/arm/armv1.d: Assemble for Armv1
and disassemble for Armv2-