Discussion:
[PATCH] RS6000/BFD: Remove dead duplicate `config.bfd' target matchers
Maciej W. Rozycki
2018-09-15 22:24:56 UTC
Permalink
Remove duplicate `rs6000-*-aix5.[01]' and `rs6000-*-aix[5-9]*' target
configuration selectors meant to correspond to `powerpc64-*-aix5.[01]'
and `powerpc64-*-aix[5-9]*' respectively for the purpose of BFD target
vector selection in `config.bfd'.

These selectors were added with commit 9a9e2ca33263 ("rs6000 xcoff bfd
config"), <https://sourceware.org/ml/binutils/2010-12/msg00372.html>,
and have been dead right from the beginning, because they appear twice
each in the case statement, which means the earlier instance of each
takes precedence and the other one is ignored. Here ones that alias to
`powerpc-*-aix5.[01]' and `powerpc-*-aix[5-9]*' respectively immediately
above are used instead.

bfd/
* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove
duplicate `case' selectors.
---
Hi Alan,

I've spotted this by chance while looking into the XFAIL list for the
SEGMENT_START test case and it looks to me like a plain oversight. If
there's something that I missed, then I'll be happy to get enlightened.

Otherwise, OK to apply?

Maciej
---
bfd/config.bfd | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

binutils-rs6000-bfd-config.diff
Index: src/bfd/config.bfd
===================================================================
--- src.orig/bfd/config.bfd
+++ src/bfd/config.bfd
@@ -1066,7 +1066,7 @@ case "${targ}" in
want64=true
;;
#ifdef BFD64
- powerpc64-*-aix5.[01] | rs6000-*-aix5.[01])
+ powerpc64-*-aix5.[01])
targ_defvec=rs6000_xcoff64_aix_vec
targ_selvecs="rs6000_xcoff_vec"
want64=true
@@ -1079,7 +1079,7 @@ case "${targ}" in
want64=true
;;
#ifdef BFD64
- powerpc64-*-aix[5-9]* | rs6000-*-aix[5-9]*)
+ powerpc64-*-aix[5-9]*)
targ_cflags=-DAIX_WEAK_SUPPORT
targ_defvec=rs6000_xcoff64_aix_vec
targ_selvecs="rs6000_xcoff_vec"
Alan Modra
2018-09-16 12:40:39 UTC
Permalink
Post by Maciej W. Rozycki
* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove
duplicate `case' selectors.
OK, thanks.
--
Alan Modra
Australia Development Lab, IBM
Maciej W. Rozycki
2018-09-20 14:54:02 UTC
Permalink
Post by Alan Modra
Post by Maciej W. Rozycki
* config.bfd <rs6000-*-aix5.[01], rs6000-*-aix[5-9]*>: Remove
duplicate `case' selectors.
OK, thanks.
Applied, thanks for your review.

Maciej

Loading...