Discussion:
[PATCH 3/8][Binutils][AArch64] Refactor err_type.
Tamar Christina
2018-09-24 17:20:43 UTC
Permalink
Hi All,

Previously the ERR_ values were defined as different constants, to make this a
bit more type safe and so they can be more easily re-used I'm changing them into
an actual enum and updating any usages.

build on native hardware and regtested on
aarch64-none-elf, aarch64-none-elf (32 bit host),
aarch64-none-linux-gnu

Cross-compiled and regtested on
aarch64-none-linux-gnu, aarch64_be-none-linux-gnu

and no issues.

Ok for master?

Thanks,
Tamar

include/
2018-09-24 Tamar Christina <***@arm.com>

* opcode/aarch64.h (enum err_type): New.
(aarch64_decode_insn): Use it.

opcodes/
2018-09-24 Tamar Christina <***@arm.com>

* aarch64-dis.c (ERR_OK, ERR_UND, ERR_UNP, ERR_NYI): Remove.
(aarch64_decode_insn, print_insn_aarch64_word): Use err_type.

--
Nick Clifton
2018-10-03 09:44:00 UTC
Permalink
Hi Tamar,
Post by Tamar Christina
include/
* opcode/aarch64.h (enum err_type): New.
(aarch64_decode_insn): Use it.
opcodes/
* aarch64-dis.c (ERR_OK, ERR_UND, ERR_UNP, ERR_NYI): Remove.
(aarch64_decode_insn, print_insn_aarch64_word): Use err_type.
Approved - please apply.

Cheers
Nick

Loading...