Discussion:
[PATCH][Binutils][AArch64] Fix bug in warning filtering.
Tamar Christina
2018-09-13 14:45:10 UTC
Permalink
Hi All,

This fixes a small bug with the warning filtering code, which when a line has
generated a warning and a template decode error (due to the way templates are
resolved) which would not have been emitted and warnings are being suppressed
with -W it would erroneously emit the error.

I have no testcase for this because the only places we generate warnings during
encoding/decoding now is using msr/mrs and system registers. They don't have a
template that would trigger this.

However an upcoming patch series will have tests in it which would expose this bug.

build on native hardware and regtested on
aarch64-none-elf, aarch64-none-elf (32 bit host),
aarch64-none-linux-gnu, aarch64_be-none-linux-gnu

Cross-compiled and regtested on
aarch64-none-linux-gnu, aarch64_be-none-linux-gnu

and no issues.

Ok for master? and for backport to binutils-2.31?

Thanks,
Tamar

gas/ChangeLog:

2018-09-13 Tamar Christina <***@arm.com>

* config/tc-aarch64.c (output_operand_error_report): Apply filtering to
current instead of head message.

--
Nick Clifton
2018-09-17 16:02:04 UTC
Permalink
Hi Tamar,
Post by Tamar Christina
Ok for master? and for backport to binutils-2.31?
Yes and yes. :-)

Cheers
Nick

Loading...